enhancement(new_relic sink): Use millisecond timestamp with metrics #21317
Conversation
This updates the metric data model for the `new_relic` sink to enhance the resolution with millisecond timestamps. Internally, it also updates the data model to use a fixed structure instead of a dynamic map for efficiency.
bruceg
added
type: enhancement
github-actions
bot
added
the
domain: sinks
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.54s Total Time |
Regression Detector ResultsRun ID: 1c1d8f6a-e401-4c36-9c60-585203711f85 Metrics dashboard Baseline: 162d9b5 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ❌ | file_to_blackhole | egress throughput | -31.07 | [-36.63, -25.50] |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | links |
|---|---|---|---|---|---|
| ➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | +1.78 | [+1.61, +1.95] | |
| ➖ | otlp_http_to_blackhole | ingress throughput | +1.75 | [+1.63, +1.88] | |
| ➖ | socket_to_socket_blackhole | ingress throughput | +1.44 | [+1.38, +1.51] | |
| ➖ | http_to_http_acks | ingress throughput | +1.24 | [+0.03, +2.45] | |
| ➖ | syslog_log2metric_humio_metrics | ingress throughput | +0.60 | [+0.49, +0.71] | |
| ➖ | http_text_to_http_json | ingress throughput | +0.24 | [+0.10, +0.39] | |
| ➖ | http_to_http_noack | ingress throughput | +0.12 | [+0.05, +0.19] | |
| ➖ | otlp_grpc_to_blackhole | ingress throughput | +0.07 | [-0.04, +0.18] | |
| ➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | +0.07 | [-0.04, +0.17] | |
| ➖ | http_to_http_json | ingress throughput | +0.03 | [-0.01, +0.06] | |
| ➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | +0.01 | [-0.07, +0.09] | |
| ➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | -0.00 | [-0.11, +0.11] | |
| ➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.00 | [-0.10, +0.09] | |
| ➖ | datadog_agent_remap_blackhole | ingress throughput | -0.08 | [-0.19, +0.03] | |
| ➖ | datadog_agent_remap_datadog_logs | ingress throughput | -0.18 | [-0.40, +0.05] | |
| ➖ | syslog_loki | ingress throughput | -0.57 | [-0.65, -0.50] | |
| ➖ | http_to_s3 | ingress throughput | -0.61 | [-0.88, -0.34] | |
| ➖ | http_elasticsearch | ingress throughput | -0.87 | [-1.04, -0.70] | |
| ➖ | syslog_splunk_hec_logs | ingress throughput | -1.12 | [-1.21, -1.02] | |
| ➖ | fluent_elasticsearch | ingress throughput | -1.37 | [-1.86, -0.87] | |
| ➖ | splunk_hec_route_s3 | ingress throughput | -1.84 | [-2.16, -1.51] | |
| ➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | -2.59 | [-2.74, -2.43] | |
| ➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -3.47 | [-3.60, -3.35] | |
| ➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -3.54 | [-3.64, -3.43] | |
| ➖ | syslog_humio_logs | ingress throughput | -3.84 | [-3.94, -3.73] | |
| ❌ | file_to_blackhole | egress throughput | -31.07 | [-36.63, -25.50] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
…ectordotdev#21317) This updates the metric data model for the `new_relic` sink to enhance the resolution with millisecond timestamps. Internally, it also updates the data model to use a fixed structure instead of a dynamic map for efficiency.
This updates the metric data model for the
new_relicsink to enhance the resolution with millisecond timestamps.Internally, it also updates the data model to use a fixed structure instead of a dynamic map for efficiency.